multiple modifications as suggested by super-linter#33
Merged
Conversation
- remove unneeded xxx.String() in log.Println() - connector/Connector.Connect() now returns an error (avoids calling log.Fatal) and is handled by caller - utils/FormatPct cleanup, using a switch statement - view handling: SetupAndValidate() can return an error, avoids log.Fatal - wrappers: use slices.SortFunc rather than sort.Slice for sorting data which is apparently more efficient. (may not matter tbh)
sjmudd
force-pushed
the
super-linter-updates
branch
from
1c172e2 to
1c1e054
Compare
- app/app_test: remove unnecesasry commented module imports - connector.Connector: check for connect errors and validate port value - utils: reduce duplicate code: add common function for comparing SumTimerWait / Name ordering
- cleanup super-linter.yml configuration - fix some spelling mistakes - connector: add nolint:gosec hint due to false positive
- super-linter did not work for me with Go so disabled it for handling Go linting - added golangci-lint explicitly to handle Go linting. This seems to work. - update go.mod for Go 1.26
… formatting - Replace curl install with go install for cleaner YAML - Use correct module path with /v2 for golangci-lint v2.x - Fix lint-locally.sh indentation (tabs for shfmt compliance)
This PR has multiple changes related to super-linter fixes and my experimentation with AI coding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The super-linter kicked in and required a large number of changes which are applied here.